Disable the navigation mode when clicking the redirect element #17798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
|
Should we add an e2e test? |
youknowriad
requested review from
ajitbohra,
gziolo,
nerrad and
ntwb
as code owners
|
@ellatrix there's already a test but it was running in edit mode directly, I updated it to force "navigation mode" |
youknowriad
force-pushed
the
fix/click-redirect
branch
from
76bf1b0 to
0b1dc06
Compare
ellatrix
approved these changes
Oct 9, 2019
| @@ -29,6 +29,9 @@ describe( 'adding blocks', () => { | |||
| } | |||
|
|
|||
| it( 'Should insert content using the placeholder and the regular inserter', async () => { | |||
| // This ensures the editor is loaded in navigation mode. | |||
| await page.reload(); | |||
There was a problem hiding this comment.
Makes me wonder if there's any value in being able to disable it per test case.
There was a problem hiding this comment.
90% of our tests require it to be disabled. Initially, I tried disabling it per test but I noticed that I was doing it for almost all the tests.
There was a problem hiding this comment.
I know, I meant having some sort of option to disable it when creating a new post for example. Maybe not worth it...
There was a problem hiding this comment.
Right! I think it's a good thing to consider. Let's see how this gets affected by #17088 when implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #17776
Clicking the empty area below the writing prompt should disable navigation mode and create a new block to start typing.
In my testing, the first click puts the caret in the title and the second creates a block, but this might be the expected behavior.
Testing instructions